GrailsFlow

Enhance logging of execution Processes/Actions in case of some errors/exception arise.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.2
  • Fix Version/s: 0.9.3, 1.0
  • Component/s: None
  • Labels:
    None
  • Request Controller:
    Albers, Stephan
  • External Supervisor:
    Voitovich, Mary
  • Executing Programmer:
    Voitovich, Mary

Description

During implementation of GPSPublishProcess.groovy (It's a description of SPLS specific workflow which we are using in SSM) we have made an error in name of action.

....
  uploadToFtp() {
            action {
                Log(messageBundle:bundle, messageKey:'message.workflow.execute.uploadToFtp')

                AssignTo(var: 'propsFile') {
                    checkFtpParams(customerId: "#customerId", errorMessage: "#errorMessage")
                }

                IF(sourceParameter: "#propsFile", comparator: '=', targetParameter: 'error') {
                    return error()
                }
                ELSE() {
                    return StoreFtp(resultVarName: "serviceResult", supplierId: "#supplierId", customerId: "#customerId", productCatalogId: "#productCatalogId", 
                                 contractId: "#contractId", exportFileName: "#exportFileName", command: 'copy', mode: 'file', propsFile: '#propsFile')
                }
            }
            on('okay').to(['postUploadToFtp'])
            on('error').to(['finishError'])
        }

.....

in reality the action "checkFtpParams" has the name "CheckFtpParamsAction.groovy" but we have written it like 'checkFtpParams' with lowercase of first character.

In result WorkFlow has been worked properly under Window OS and CheckFtpParamsAction is executed, but under Linux OS (case sensitive file system) the execution of this node lead to wrong result.
We can not found the reason of this problem a long time because in the logs we didn't see information that checkFtpParamsAction is not found or some exception connected with it. From log we saw only the error of execution the next Action - StoreFtpAction (the NullPointerException thrown here).

We need to add error messages + stack traces in log in case of some errors arose during compilation/execution Actions.

Activity

There are no comments yet on this issue.

People

Vote (0)
Watch (0)

Dates

  • Created:
    11/Mar/09 3:42 PM
    Updated:
    06/Jul/09 9:12 PM
    Resolved:
    06/Jul/09 9:11 PM