GrailsFlow

Introduce enumerations for process and node statuses

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.0.12
  • Component/s: None
  • Labels:
    None
  • Request Controller:
    Please Select
  • External Supervisor:
    Please select
  • Executing Programmer:
    Antonicheva, July
  • Estimated Hours:
    8
  • Ext Project Id:
    JCGFW-01

Description

We use FlowStatus table to store/get statuses that are used in processes and nodes. But every time when we need some status (f.e. ACTIVATED or COMPLETED) we get it from DB using hardcoded statusID string, like FlowStatus.findByStatusID("ACTIVATED"). That is inconvenient.
Another aspect - not all statuses are used in processes, for example statuses 'running', 'forwarded', 'pending', 'stopped', 'await_callback' are used only for nodes but we have them in search form on process list page (in status search field). It makes no sense.

Proposals:

  • introduce two enumerations, like NodeStatusEnum and ProcessStatusEnum - they are represented statuses;
  • use enums instead of hardcoded statusIDs in code;
  • update UIs - search fields for statuses should contain only values from right enumeration, e.g. if we have search for nodes - NodeStatusEnum values, if search selectbox for processes - ProcessStatusEnum;

Activity

Hide
Antonicheva, July added a comment - 13/Feb/12 7:14 AM

Done. Please check changes.

Show
Antonicheva, July added a comment - 13/Feb/12 7:14 AM Done. Please check changes.
Hide
Shwedovsky, Dmitry added a comment - 15/Feb/12 1:15 PM

Checked.
For Process List displayed only statuses:ACTIVATED SUSPENDED COMPLETED KILLED.

Show
Shwedovsky, Dmitry added a comment - 15/Feb/12 1:15 PM Checked. For Process List displayed only statuses:ACTIVATED SUSPENDED COMPLETED KILLED.

People

Vote (0)
Watch (0)

Dates

  • Created:
    07/Feb/12 9:04 AM
    Updated:
    24/Feb/12 8:41 AM
    Resolved:
    24/Feb/12 8:41 AM