GrailsFlow

• Type: New Feature
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: None
• Fix Version/s: 1.1
• Component/s: None
• Labels:

  None

If you pass many parameters to an action, it's hard to see which parameters are input and which are output parameters.
(this is also a Groovy problem; do we really want to change this?)
Answer: Why is it Groovy problem. I can not understand it. It's a design of GrailsFlow as I see. It must be discussed.

This Node "ImportConversion" calls ImportConversionHL and we pass many parameters to this Action. Unfortunately, from this call it's not clear which parameters are input (will not be changed in the Action) and which are output (will be changed in the Action).

importConversion(isStart: true) {
            action {
                ImportConversionHL(catalogId: "#catalogId", customerId: "#customerId",
                        supplierId: "#supplierId", fileName: "#fileName", format: "#format",
                        workflowError: "#workflowError", errorMessage: "#errorMessage",
                        cmlFile: "#cmlFile", cmlVersion: "#cmlVersion")
                IF(sourceParameter: "#workflowError", comparator: '!=', targetParameter: 'true') {
                    return okay()
                }
                ELSE() {
                    return error()
                }
            }
            on('okay').to(['catalogValidation'])
            on('error').to(['finishError'])
        }

Would nice to have something like:

........
 ImportConversionHL() {
        input(catalogId: "#catalogId", customerId: "#customerId",
                        supplierId: "#supplierId", fileName: "#fileName", format: "#format",)
        output( workflowError: "#workflowError", errorMessage: "#errorMessage",
                        cmlFile: "#cmlFile", cmlVersion: "#cmlVersion")
}
...........

• Assignee:

  Albers, Stephan

  Reporter:

  Staskov, Ivan

• Created:

  11/Mar/10 4:55 PM

  Updated:

  31/Mar/10 4:42 PM